search

pytorn / hackr

A python library for hackathons.
Apache License 2.0
94 stars 31 forks source link

[WIP]Adding image scraping #42

Closed ba11b0y closed 6 years ago

ba11b0y commented 7 years ago

Adds to #18 I know it is violating the do not repeat yourself(DRY) principle, as I am not clear how should I include this addition. @ashwini0529 If you could tell me if this is fine or should I improve upon the structure.

ashwini0529 commented 7 years ago

Included in requirements.txt?

ba11b0y commented 7 years ago

@ashwini0529 I have updated the requirements as well as the usage. Please let me know if any corrections are needed. Also I was thinking of defining a function outside the scope of the scrape function, to eliminate repetition of the code for scraping images. Since that would be a major change to the code style, your thoughts?

ashwini0529 commented 7 years ago

Hey @invinciblycool I guess that would be better. 😄 Please go ahead with it! 🎉

ba11b0y commented 7 years ago

@ashwini0529 I accidentally squashed the wrong number of commits. What should I do now? :worried: Closing the PR can be a solution, but is there any way out without closing the PR.

ba11b0y commented 7 years ago

@ashwini0529 Then should I open a new PR, and close this. Sorry again for the mess. :worried: I guess I need to go through squashing commits once again.

ashwini0529 commented 6 years ago

Haha Alright! You could fix it in this PR but if you think that opening a new PR would be easy as of now, go ahead! 👍

ba11b0y commented 6 years ago

Done. @ashwini0529 Intentionally kept the three commits instead of squashing them into one.