search

pytorn / hackr

A python library for hackathons.
Apache License 2.0
94 stars 31 forks source link

Restructure generator.py according to the utilities #8

Open ashwini0529 opened 7 years ago

ashwini0529 commented 7 years ago

As of now, there are multiple functionalities implemented in a single file. Most of the generator functions are Faker oriented. Maybe a separate file handles such functions.

theycallmemac commented 7 years ago

Just had a look at this. You want the functions using Faker to be separated from the few that don't?

ashwini0529 commented 7 years ago

Yeah basically the purpose of generator is to generate data. Now that maybe using Faker, built-in functions, or any other way. generator.py should be in such a way, that it should not contain much of a repeated code, or functions.

theycallmemac commented 7 years ago

So rather than having separate files handling such functions as you've said above, this is just a refactoring issue?

ashwini0529 commented 7 years ago

Yeah kind of refactoring issue.

ashwini0529 commented 7 years ago

Hey @theycallmemac , can you please check a comment that I made on your PR? That would be ready to merge then. 🎉

theycallmemac commented 7 years ago

Isn't it merged already?