pytr-org / pytr

Use TradeRepublic in terminal and mass download all documents
https://pypi.org/project/pytr/
MIT License
418 stars 73 forks source link

Export Account Transactions has wrong tax #141

Open ralfescher opened 3 days ago

ralfescher commented 3 days ago

Hi,

I am a beginner in Python programming and managed to get this (great) program running under a virtual Python 3.9 on my new Mac mini.

While exporting the transactions dl_docs, I noticed that the taxes were incorrectly displayed.

Output: 2024-11-01;Interest;187.16;Zinsen;;;;-6,704 The real value is: 187,16€ and 67,04€ tax (instead of 6704€).

Additionally, I have the problem of importing .csv files into Excel on my Mac (German locale) (comma/period and UTF-8 -> Mac-Roman). Would it make sense to offer a specific option for this?

Additional question: Does it make sense to get this app running under Python 3.12 as well? (As mentioned, I’m new to Python).

Thanks Ralf

pinzutu commented 2 days ago

Hi, you can change pytr's csv locale using the export_transactions --lang argument. Excel should also be able to parse semicolumn separated csvs.

Furthermore, could you share the (redacted) json entry of the event with the erroneous tax (all_events.json)?

msdn65 commented 2 days ago

In account_transactions.csv I also get wrong or malformatted tax: 2024-11-01;INTEREST;146.51;Zinsen;;;;-3,137

snippet from all_events.json: { "title": "Transaktion", "data": [ { "title": "Angesammelt", "style": "plain", "detail": { "text": "€177.88", "type": "text" } }, { "title": "Steuern", "style": "plain", "detail": { "text": "€31.37", "type": "text" } }, { "title": "Gesamt", "style": "plain", "detail": { "text": "€146.51", "type": "text" } } ], "type": "table" },

ralfescher commented 1 day ago

I have the same situation: the values in the JSON look correct (as with @msdn65) Btw. the command pytr export_transactions does not export the interests to the csv file.