pytr-org / pytr

Use TradeRepublic in terminal and mass download all documents
https://pypi.org/project/pytr/
MIT License
425 stars 76 forks source link

Improve handling of multiple credentials #144

Open RealCLanger opened 6 days ago

RealCLanger commented 6 days ago

Hi,

I'm taking another attempt to fix #38 (Session is not invalidated when a new login with different number occurs) which hits me as well. There has already be an effort in #56 but it seems that this went stale.

My idea is to store the cookies in a file that is named after the phone number which is the id of a trade republic account. So there can be no conflicts in cookies if the tool is used with multiple accounts.

I also remove the prompt that asks whether one would like to save the credentials and replace it with a command line option --store_credentials which defaults to true. I find the prompt rather annoying, especially for scripted calls of pytr.

Comments/Suggestions?

Cheers Christoph