search

pytransitions / transitions

A lightweight, object-oriented finite state machine implementation in Python with many extensions
MIT License
5.52k stars 525 forks source link

Added coverage for duplicate states in HierarchicalMachine #406

Closed thedrow closed 4 years ago

thedrow commented 4 years ago

Coverage for these conditions were missing so I added them :smiley:.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.09%) to 98.612% when pulling 4ed2e3cf6c8f9644fe6cb6382fd4f5482684afcd on thedrow:increase-coverage into 070b45047a7d9c253401a39086b0f1ccc5b8dfc4 on pytransitions:master.

aleneum commented 4 years ago

Nice! Could you add those tests to test_enum.py instead (in particular here)? This will make sure that users of Python 2.7 without the enum34 module can run the tests as well (since enum tests will be skipped).

I see that Travis' Python 2.7 job is not failing suprisingly. More surprisingly, the tests are actually executed instead of skipped. Maybe enum34 is installed by default since it is no dependency of transitions. When I run tests locally, test_enum will be skipped for Python 2.7.

thedrow commented 4 years ago

I was about to do the changes you requested today. Do I need to do them anyway or are you going to do so?