Closed aleneum closed 1 month ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
8ab2529
) 98.40% compared to head (4c7ae1f
) 98.40%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Exception
is not broad enough and does not catchasyncio.CancelledError
orKeyboardInterrupt
.transitions
will exclusively catchBaseException
from now on.This has to major implications: First
on_exception
is not called when a task is cancelled. This will happen when an asynchronous event cancels currently running callbacks or a KeyboardInterrupt is called. Second, whenqueue=True
CancelledError
will not cause the queue to get cleared and render the machine unusable from thereon.