search

pytries / datrie

Fast, efficiently stored Trie for Python. Uses libdatrie.
http://pypi.python.org/pypi/datrie/
GNU Lesser General Public License v2.1
530 stars 88 forks source link

Installation fails with Python 3.7 #52

Closed ozcan closed 5 years ago

ozcan commented 6 years ago

Hi,

Python 3.7 introduced some ABI changes which require auto-generated C files to be updated. Is new release planned?

Best,

andersgs commented 6 years ago

Manual workaround:

Download and unpack the tar.gz. cd into the folder run update_c.sh python3.7 setup.py build python3.7 setup.py install

wget https://github.com/pytries/datrie/archive/0.7.1.tar.gz
tar xf 0.7.1.tar.gz
cd datrie-0.7.1
./update_c.sh
python3.7 setup.py build
python3.7 setup.py install

Ideally, the setup.py would be updated so that Cython could be used to update the source files as needed.

Thank you.

rraadd88 commented 5 years ago

It's an issue with python=3.7 right now. Works very well with python=3.6.

gokceneraslan commented 5 years ago

or just use conda: conda install datrie. They have a binary package for Python 3.7

sjackman commented 5 years ago

I'm still seeing this build failure with Python 3.7 and datrie 0.7.1. Could a new release of datrie with support for Python 3.7 be tagged and pushed to PyPI?

sjackman commented 5 years ago

pip3 install datrie fails with Python 3.7. Install from git is a workaround:

pip3 install git+https://github.com/pytries/datrie.git
MikedeKokkie commented 5 years ago

pip3 install datrie fails with Python 3.7. Install from git is a workaround:

pip3 install git+https://github.com/pytries/datrie.git

You're a lifesaver, thank you!

sjackman commented 5 years ago

@superbobry Hi, Sergei. Could you please tag and release a new version of datrie and update the package on PyPI? pip3 install datrie currently fails with Python 3.7.

ivan-krukov commented 5 years ago

@superbobry @kmike Hello. I'm sorry to bring this up, but this issue shouldn't be closed until the updated version is on PyPI. Other things that depend on pytries, most notably, snakemake, fail to install. Please, please, push this to PyPI. Thank you.

bast commented 5 years ago

I also now fell into this when pip installing Snakemake on 3.7 - the workaround worked. On Wednesday I will teach Snakemake at a workshop :-) Is there a good reason for not updating PyPI yet? Please don't get me wrong, I am not complaining: "not having time to do this yet" would be a good reason. I really appreciate you sharing and maintaining this code. Anything I/we can help with to get a new version out on PyPI?

idaL commented 5 years ago

Building a software that relies on dantrie, we also need a newer version that works with python 3.7. Really appreciate you maintaining this code. (: