search

pytries / datrie

Fast, efficiently stored Trie for Python. Uses libdatrie.
http://pypi.python.org/pypi/datrie/
GNU Lesser General Public License v2.1
530 stars 88 forks source link

Added serializing into `bytes` object #71

Open KOLANICH opened 4 years ago

KOLANICH commented 4 years ago

This PR requires https://github.com/tlwg/libdatrie/pull/12 to be merged first (or maybe create an own fork of that lib, because that fork is inactive).

KOLANICH commented 4 years ago

@kmike, @jdufresne, @cclauss

KOLANICH commented 4 years ago

https://gitlab.com/KOLANICH-subgroups/packages/datrie/-/jobs/artifacts/master/raw/wheels/datrie-0.CI_python-py3-none-any.whl?job=build

tacaswell commented 4 years ago

@KOLANICH This requires a re-base.

tacaswell commented 4 years ago

Thank you, but we are still waiting on the PR (and release?) in libdatrie for this to be mergeable? What commit is the submodule pointing at now?

KOLANICH commented 4 years ago

I have sent there a PR, but when a PR is sent, GH puts the commits into the repo (proof), so submodules should work even if that PR is not merged yet.

tacaswell commented 4 years ago

if the PR gets closed without being merged or you change the PR (either by just adding more commits or by force-pushing new commits) what will make sure the commit we are relying on here does not get "garbage collected" by github?

KOLANICH commented 4 years ago

If it is your concern, you can fork that repo and fetch the branch from mine. I don't want to tie this project to my fork of that repo because I plan to delete it as soon as everything I need merged.

tacaswell commented 3 years ago

The upstream PR still appears to not be merged?

KOLANICH commented 3 years ago

@tacaswell, it's merged into the upstream.

KOLANICH commented 3 years ago

@tacaswell

KOLANICH commented 3 years ago

@tacaswell

KOLANICH commented 3 years ago

@tacaswell