search

pytries / datrie

Fast, efficiently stored Trie for Python. Uses libdatrie.
http://pypi.python.org/pypi/datrie/
GNU Lesser General Public License v2.1
530 stars 88 forks source link

Yet another PR to fix py38 #80

Closed tacaswell closed 4 years ago

tacaswell commented 4 years ago

This is a slightly simplified version of #78 (which in turn is merging #76 and #69). It makes cython a required install time dependency, but cython is pip installable (it is typically harder to get a working compiler than a working cython).

To address those cases we should sort out how to build manylinux, (ex https://github.com/pypa/python-manylinux-demo), mac, and windows wheels.

A simpler version of this patch has already been applied to the conda-forge feedstock (https://github.com/conda-forge/datrie-feedstock/pull/5) to get py38 builds up.

tacaswell commented 4 years ago

And I now see that #69 includes commits from #54.

Closes #69 closes #54 closes #76 closes #78

tacaswell commented 4 years ago

CI has passed, but not reported back.

tacaswell commented 4 years ago

self-merged on @ashwinvis 's approval and https://github.com/pytries/datrie/issues/81#issuecomment-604099451