Closed superbobry closed 7 years ago
I think these two should be deprecated in favour of their path-based friends.
Three reasons:
The methods only work on file objects and produce ugly error messages when called on e.g. BytesIO:
BytesIO
>>> import io >>> import marisa_trie >>> marisa_trie.Trie().write(io.BytesIO()) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "src/marisa_trie.pyx", line 193, in marisa_trie._Trie.write (src/marisa_trie.cpp:4201) self._trie.write(f.fileno()) io.UnsupportedOperation: fileno
mmap
@kmike, what do you think?
I think these two should be deprecated in favour of their path-based friends.
Three reasons:
The methods only work on file objects and produce ugly error messages when called on e.g.
BytesIO
:mmap
lacks a file-based version.@kmike, what do you think?