pytries / marisa-trie

Static memory-efficient Trie-like structures for Python based on marisa-trie C++ library.
https://marisa-trie.readthedocs.io/en/latest/
MIT License
1.03k stars 91 forks source link

Install failing #34

Closed fmailhot closed 7 years ago

fmailhot commented 7 years ago
 $ pip install marisa-trie==0.7.3
Collecting marisa-trie==0.7.3
  Using cached marisa-trie-0.7.3.tar.gz
Building wheels for collected packages: marisa-trie
  Running setup.py bdist_wheel for marisa-trie ... error
  Complete output from command /Users/fredmailhot/anaconda/envs/marisa_test/bin/python -u -c "import setuptools, tokenize;__file__='/private/var/folders/h4/p3tnqg5n1rg54phgp1_g_8s00000gp/T/pip-build-qDhwKQ/marisa-trie/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /var/folders/h4/p3tnqg5n1rg54phgp1_g_8s00000gp/T/tmpA7YRglpip-wheel- --python-tag cp27:
  running bdist_wheel
  running build
  running build_clib
  building 'libmarisa-trie' library
  creating build
  creating build/temp.macosx-10.7-x86_64-2.7
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire/io
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire/trie
  creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire/vector
  gcc -fno-strict-aliasing -I/Users/fredmailhot/anaconda/envs/marisa_test/include -arch x86_64 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Imarisa-trie/lib -Imarisa-trie/include -c marisa-trie/lib/marisa/agent.cc -o build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/agent.o
  marisa-trie/lib/marisa/agent.cc:3:10: fatal error: 'marisa/agent.h' file not found
  #include "marisa/agent.h"
           ^
  1 error generated.
  error: command 'gcc' failed with exit status 1

  ----------------------------------------
  Failed building wheel for marisa-trie
  Running setup.py clean for marisa-trie
Failed to build marisa-trie
Installing collected packages: marisa-trie
  Running setup.py install for marisa-trie ... error
    Complete output from command /Users/fredmailhot/anaconda/envs/marisa_test/bin/python -u -c "import setuptools, tokenize;__file__='/private/var/folders/h4/p3tnqg5n1rg54phgp1_g_8s00000gp/T/pip-build-qDhwKQ/marisa-trie/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /var/folders/h4/p3tnqg5n1rg54phgp1_g_8s00000gp/T/pip-vupQHV-record/install-record.txt --single-version-externally-managed --compile:
    running install
    running build
    running build_clib
    building 'libmarisa-trie' library
    creating build
    creating build/temp.macosx-10.7-x86_64-2.7
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire/io
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire/trie
    creating build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/grimoire/vector
    gcc -fno-strict-aliasing -I/Users/fredmailhot/anaconda/envs/marisa_test/include -arch x86_64 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Imarisa-trie/lib -Imarisa-trie/include -c marisa-trie/lib/marisa/agent.cc -o build/temp.macosx-10.7-x86_64-2.7/marisa-trie/lib/marisa/agent.o
    marisa-trie/lib/marisa/agent.cc:3:10: fatal error: 'marisa/agent.h' file not found
    #include "marisa/agent.h"
             ^
    1 error generated.
    error: command 'gcc' failed with exit status 1
FrederikP commented 7 years ago

Can confirm. The same is happening to me with the new version.

rooterkyberian commented 7 years ago

pretty sure lib/marisa-trie submodule was not included in pypi release, as the same happens if you checkout this repository and don't run git submodule update --init --recursive before running setup.py

rooterkyberian commented 7 years ago

I was wrong, it is only .h files that are not included

superbobry commented 7 years ago

Thanks! It seems I forgot to update the Travis CI script.

I've deleted the release from PyPI. Will re-do it properly in a few days.