search

pytries / marisa-trie

Static memory-efficient Trie-like structures for Python based on marisa-trie C++ library.
https://marisa-trie.readthedocs.io/en/latest/
MIT License
1.02k stars 91 forks source link

Add support for the trie.map method #90

Closed duilio closed 11 months ago

duilio commented 11 months ago

map restores an instance of a Trie from memory.

duilio commented 11 months ago

I've just realized the test suite doesn't run against Python 2.x, I've only added the PY2 compat code for the buffer protocol because I saw the Python 2 classifier in setup.py, I guess it would be better to remove the compat code and the classifier which is there probably for legacy reasons?

BoboTiG commented 11 months ago

You are right, it's time to say goodbye to Python 2.

~Do you think you can do it in a separate PR (if you was thinking about doing it yourself, of course)?~ I'll do it :)

BoboTiG commented 11 months ago

OK that's done in #91. If you can rebase your branch then, I'll unlock the CI.

duilio commented 11 months ago

@BoboTiG branch rebased. ;-)

BoboTiG commented 11 months ago

Thanks a lot @duilio 🍾