search

pytroll / aggdraw

Python package wrapping AGG2 drawing functionality
https://aggdraw.readthedocs.io/en/latest/
Other
98 stars 48 forks source link

Also build wheels for python 3.8 #66

Closed mboelens91 closed 4 years ago

mboelens91 commented 4 years ago

Currently no wheels are created for python 3.8. This prs also creates these which removes the need to build them locally

mraspaud commented 4 years ago

Thanks for this PR! I see the tests are failing, is this something to be expected @djhoese ?

djhoese commented 4 years ago

I think this is expected with some of the changes in cibuildwheel where it now tries to build PyPy packages. I'll have to look closer later.

That said, this reminds me that there were still some differences with the current master branch that is unreleased (see #61). This was especially noticeable in the pytroll pycoast package. I never got around to fixing them. I thought I had an issue to discuss it but can't find it now so maybe I never made it.

Regardless, thanks for the PR. I'll see what I can do even if that means adding this to a maintenance branch.

djhoese commented 4 years ago

So coming back to this: these changes won't actually enable python 3.8 wheels to be built. The "astropy" build modes are actually the testing environments that don't build wheels. I'm going to try something hacky and just rerun the build for the last release and see if it builds the new wheels.

Edit: For reference: https://travis-ci.org/github/pytroll/aggdraw/builds/559228184

mboelens91 commented 4 years ago

ah not too familiar with the way this project builds so was mostly a guess on how to fix it indeed. rerunning it seems to have created the mac version for 3.8 it seems. only the linux one seems to have failed. it's a bit weird that it seems to run the tests fine the first time and then the second time it suddenly fails.

djhoese commented 4 years ago

Ah nice. I didn't even see that the OSX ones worked. I will work on figuring things out with this package in the next month or so (I hope :fearful: ) and that will include a new release with 3.8 wheels (and drop python 2.7 support).