sfinkens commented 2 years ago

Fixes #103

djhoese commented 2 years ago

I would recommend checking out what I did in Satpy:

https://github.com/pytroll/satpy/blob/main/.readthedocs.yml

This includes converting warnings into errors and also uses mamba instead of conda.

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (a33bbdc) into main (fd48442) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   72.93%   72.93%           
=======================================
  Files          32       32           
  Lines        2830     2830           
=======================================
  Hits         2064     2064           
  Misses        766      766

Impacted Files	Coverage Δ
pygac/calibration.py	`94.21% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sfinkens commented 2 years ago

@djhoese That's what I started with (thanks!) and then deleted the fail_on_warnings entry :sweat_smile: I'll put it back in. If I understand the docs correctly, RTD will use mamba with python: "mambaforge-4.10" , correct?

djhoese commented 2 years ago

Yeah that whole structure in the config of ubuntu and python mamba.

pytroll / pygac

Add conda environment for readthedocs #110

Codecov Report