pytroll / pygac

A python package to read and calibrate NOAA and Metop AVHRR GAC and LAC data
https://pygac.readthedocs.org/
GNU General Public License v3.0
20 stars 25 forks source link

Don't use deprecated distutils module. #122

Closed sebastic closed 1 year ago

sebastic commented 1 year ago

pygac/reader.py still uses the deprecated distutils which will be removed in Python 3.12.

From What’s New In Python 3.10:

The entire distutils package is deprecated, to be removed in Python 3.12. Its functionality for specifying package builds has already been completely replaced by third-party packages setuptools and packaging, and most other commonly used APIs are available elsewhere in the standard library (such as platform, shutil, subprocess or sysconfig). There are no plans to migrate any other functionality from distutils, and applications that are using other functions should plan to make private copies of the code. Refer to PEP 632 for discussion.

Porting from Distutils suggests using packaging.version instead of distutils.version.

codecov[bot] commented 1 year ago

Codecov Report

Merging #122 (2e01ce1) into main (748774e) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 2e01ce1 differs from pull request most recent head 4d68750. Consider uploading reports for the commit 4d68750 to get more accurate results

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          32       32           
  Lines        2882     2882           
=======================================
  Hits         2144     2144           
  Misses        738      738           
Impacted Files Coverage Δ
pygac/reader.py 81.77% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.