search

pytroll / pygac

A python package to read and calibrate NOAA and Metop AVHRR GAC and LAC data
https://pygac.readthedocs.org/
GNU General Public License v3.0
21 stars 27 forks source link

Extract calibration modules from the reader #127

Closed mraspaud closed 2 months ago

mraspaud commented 7 months ago

This PR extracts calibration modules from the reader.

As we are preparing to add new calibration and navigation algorithms for pygac, it needs to be upgraded to be made more modular.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 98.12734% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (298252f) to head (806fec3). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pygac/reader.py 95.57% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #127 +/- ## ========================================== + Coverage 74.22% 76.11% +1.89% ========================================== Files 33 32 -1 Lines 3115 3195 +80 ========================================== + Hits 2312 2432 +120 + Misses 803 763 -40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mraspaud commented 2 months ago

@sfinkens if you could review again, that would be great :) I have address all you comment I think, and did some more refactoring. I need to do more, but I will do that in another PR, along with extracting the navigation module.