search

pytroll / pygac

A python package to read and calibrate NOAA and Metop AVHRR GAC and LAC data
https://pygac.readthedocs.org/
GNU General Public License v3.0
20 stars 25 forks source link

add METOP C coefficients #86

Closed distein closed 3 years ago

distein commented 3 years ago

Add provisional metop-c calibration coefficients as received via e-mail from Mike F. (20200922)

sfinkens commented 3 years ago

Oh, the cecksum of the coefficient file has to be updated as well, right @carloshorn ?

carloshorn commented 3 years ago

Hi @distein,

Thanks for providing these coefficients. Sorry for the late reply, I was on vacation the last two weeks.

Oh, the checksum of the coefficient file has to be updated as well, right @carloshorn ?

Correct! We should add a test for the checksum, so we never forget to update it in the future.

sfinkens commented 3 years ago

@carloshorn One test is already checking that: https://github.com/pytroll/pygac/blob/master/pygac/tests/test_calibration_coefficients.py#L178 . It fails if the coefs are not recognized.

carloshorn commented 3 years ago

One test is already checking that: [...]

Good, then I am fine with all the changes.

ghost commented 3 years ago

Congratulations :tada:. DeepCode analyzed your code in 21.092 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

sfinkens commented 3 years ago

As proposed by @mraspaud I added a status key to the coefficient dictionary which can be used to issue warnings if non-nominal coefficients are used.

mraspaud commented 3 years ago

Looks good now! :)

mraspaud commented 3 years ago

Feel free to merge