Closed distein closed 3 years ago
Oh, the cecksum of the coefficient file has to be updated as well, right @carloshorn ?
Hi @distein,
Thanks for providing these coefficients. Sorry for the late reply, I was on vacation the last two weeks.
Oh, the checksum of the coefficient file has to be updated as well, right @carloshorn ?
Correct! We should add a test for the checksum, so we never forget to update it in the future.
@carloshorn One test is already checking that: https://github.com/pytroll/pygac/blob/master/pygac/tests/test_calibration_coefficients.py#L178 . It fails if the coefs are not recognized.
One test is already checking that: [...]
Good, then I am fine with all the changes.
Congratulations :tada:. DeepCode analyzed your code in 21.092 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.
As proposed by @mraspaud I added a status
key to the coefficient dictionary which can be used to issue warnings if non-nominal coefficients are used.
Looks good now! :)
Feel free to merge
Add provisional metop-c calibration coefficients as received via e-mail from Mike F. (20200922)