pytroll / pyorbital

Orbital and astronomy computations in python
http://pyorbital.readthedocs.org/
GNU General Public License v3.0
220 stars 75 forks source link

Update celestrak urls #138

Closed dagnic closed 6 months ago

dagnic commented 6 months ago

Celestrak starts to remove the legacy tle txt files. I've detected a 404 error on the active one and asked T.S. Kelso; he points me to this post on X. I now suggest to use the query links.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (137e201) 87.50% compared to head (7d40562) 87.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #138 +/- ## ======================================= Coverage 87.50% 87.51% ======================================= Files 14 14 Lines 2209 2210 +1 ======================================= + Hits 1933 1934 +1 Misses 276 276 ``` | [Flag](https://app.codecov.io/gh/pytroll/pyorbital/pull/138/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pytroll/pyorbital/pull/138/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `87.51% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 6 months ago

Coverage Status

coverage: 87.562% (+0.006%) from 87.556% when pulling 7d40562e58b99831f2638f08298838ce99c2956d on dagnic:main into 137e201b1c0119a75ce0c00ea92815ba25e46703 on pytroll:main.

djhoese commented 6 months ago

How urgent is this fix needed? I have almost zero experience with this package but I also don't remember when all of the people who do have experience are coming back from holiday time off.

dagnic commented 6 months ago

I would say quite urgent because without the fix, it is not possible to get the satellite orbital parameters through the API. If you need time, one can either: