search

pytroll / pyorbital

Orbital and astronomy computations in python
http://pyorbital.readthedocs.org/
GNU General Public License v3.0
224 stars 77 forks source link

Make `get_observer_look` work on oblate earth #87

Open mraspaud opened 2 years ago

mraspaud commented 2 years ago

The pyorbital code to compute the observer look was making the assumption that the earth was spherical. While the differences are quite small, we implement here the oblateness of the earth into the function.

codecov[bot] commented 2 years ago

Codecov Report

Merging #87 (6785eed) into main (e215868) will decrease coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   85.67%   85.55%   -0.12%     
==========================================
  Files          13       13              
  Lines        1947     1932      -15     
==========================================
- Hits         1668     1653      -15     
  Misses        279      279
Flag Coverage Δ
unittests 85.55% <100.00%> (-0.12%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyorbital/orbital.py 86.60% <100.00%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e215868...6785eed. Read the comment docs.