pytroll / pyorbital

Orbital and astronomy computations in python
http://pyorbital.readthedocs.org/
GNU General Public License v3.0
224 stars 77 forks source link

Fix bogus designator assignment #92

Closed mraspaud closed 2 years ago

mraspaud commented 2 years ago

The designator assignment during TLE parsing was wrong due to an enthusiastic refactoring in 958050ff961fd45ccaed95b1ab7a7bf6692a9a77. This PR restores the functionality and adds a test for it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #92 (bf67403) into main (523099d) will increase coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   86.67%   86.86%   +0.19%     
==========================================
  Files          13       13              
  Lines        2026     2048      +22     
==========================================
+ Hits         1756     1779      +23     
+ Misses        270      269       -1     
Flag Coverage Δ
unittests 86.86% <100.00%> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyorbital/tests/test_tlefile.py 97.99% <100.00%> (+0.15%) :arrow_up:
pyorbital/tlefile.py 91.34% <100.00%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 523099d...bf67403. Read the comment docs.

mraspaud commented 2 years ago

LGTM. Should we also test cases without any platform name within the TLE file?

Test added!