djhoese commented 1 year ago

As described in https://github.com/pytroll/python-geotiepoints/pull/38 I discovered that the default weight_delta_max in the dask EWA code did not match the docstring. The docstring is correct for MODIS data and matches what has been in the EWA algorithm forever (it was originally written for MODIS code).

I really don't want to add a test for this.

[ ] Tests added
[ ] Tests passed
[ ] Passes git diff origin/main **/*py | flake8 --diff

djhoese commented 1 year ago

Wow, turns out it was wrong in the legacy resampler too. Fixed in both now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #463 (162125d) into main (c56533c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files          69       69           
  Lines       12394    12394           
=======================================
  Hits        11686    11686           
  Misses        708      708

Flag	Coverage Δ
unittests	`94.28% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pyresample/ewa/_legacy_dask_ewa.py	`84.69% <ø> (ø)`
pyresample/ewa/dask_ewa.py	`90.16% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

coveralls commented 1 year ago

Coverage remained the same at 93.791% when pulling 162125d5399ceba01c01bf49858757ccb7f3a6fa on djhoese:bugfix-dask-ewa-defaults into c56533c9a44b6078e6cf38254c76728cb06ad588 on pytroll:main.

pytroll / pyresample

Fix EWA default for 'weight_delta_max' to match docstring #463

Codecov Report