Codecov Report

Merging #478 (6f338fd) into main (6ff3568) will increase coverage by 0.35%. The diff coverage is 99.43%.

:exclamation: Current head 6f338fd differs from pull request most recent head a681248. Consider uploading reports for the commit a681248 to get more accurate results

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   94.27%   94.62%   +0.35%     
==========================================
  Files          78       76       -2     
  Lines       12838    13701     +863     
==========================================
+ Hits        12103    12965     +862     
- Misses        735      736       +1

Flag	Coverage Δ
unittests	`94.62% <99.43%> (+0.35%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pyresample/future/spherical/arc.py	`95.93% <95.93%> (ø)`
pyresample/future/spherical/__init__.py	`100.00% <100.00%> (ø)`
pyresample/future/spherical/point.py	`100.00% <100.00%> (ø)`
pyresample/spherical.py	`92.63% <100.00%> (-0.04%)`	:arrow_down:
pyresample/test/test_sgeom/test_arc.py	`100.00% <100.00%> (ø)`
pyresample/test/test_sgeom/test_point.py	`100.00% <100.00%> (ø)`
pyresample/test/conftest.py	`98.01% <0.00%> (-0.39%)`	:arrow_down:
pyresample/geometry.py	`87.40% <0.00%> (-0.15%)`	:arrow_down:
pyresample/test/test_kd_tree.py	`97.31% <0.00%> (-0.05%)`	:arrow_down:
pyresample/test/test_dask_ewa.py	`98.94% <0.00%> (-0.01%)`	:arrow_down:
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

coveralls commented 1 year ago

Coverage increased (+0.4%) to 94.174% when pulling 6f338fdc52649c02abce817cf787e78b18dcf06e on ghiggi:feature-sarc into 952cec6ee4bce55bb70f2c1237401356645bc3f6 on pytroll:main.

djhoese commented 1 year ago

Looks like some of the github suggestions from my comments or your other recent changes have messed a few things up. Pre-commit and stickler and the website building are all mad.

ghiggi commented 1 year ago

@djhoese I think now the code is ready for another round of review ;)

djhoese commented 1 year ago

Looks like one of the tests is failing with the unstable dependencies. Not sure what's up with that.

pytroll / pyresample

[Future Spherical Class] Add SArc #478

Codecov Report