pytroll / pyresample

Geospatial image resampling in Python
http://pyresample.readthedocs.org
GNU Lesser General Public License v3.0
346 stars 94 forks source link

Deprecate AreaDefinition 'rotation' argument #496

Closed djhoese closed 1 year ago

djhoese commented 1 year ago

After talking with @loreclem on slack, we decided that it should be OK to deprecate the functionality added by him via the rotation keyword argument in the AreaDefinition. As far as I know this functionality was not used by anyone (even Lorenzo doesn't use it anymore) and should be replaced by parameters to the CRS (projection) being defined for the area. Overall, I wanted to remove this to cleanup code that was/is likely not being used by anyone and only makes the code harder to maintain.

Note: This PR is based on #464 so it has a lot of commits and changes that will go away when that PR is merged.

codecov[bot] commented 1 year ago

Codecov Report

Merging #496 (347019d) into main (f770984) will increase coverage by 0.32%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   93.94%   94.27%   +0.32%     
==========================================
  Files          78       78              
  Lines       12920    12838      -82     
==========================================
- Hits        12138    12103      -35     
+ Misses        782      735      -47     
Flag Coverage Δ
unittests 94.27% <100.00%> (+0.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyresample/test/test_geometry/test_area.py 99.18% <ø> (ø)
pyresample/test/test_geometry_legacy.py 97.64% <ø> (-0.16%) :arrow_down:
pyresample/test/test_utils.py 100.00% <ø> (ø)
pyresample/area_config.py 90.44% <100.00%> (-0.21%) :arrow_down:
pyresample/geometry.py 87.55% <100.00%> (+0.09%) :arrow_up:
pyresample/_spatial_mp.py 82.94% <0.00%> (+17.05%) :arrow_up:
pyresample/_multi_proc.py 83.01% <0.00%> (+39.62%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

coveralls commented 1 year ago

Coverage Status

Coverage: 93.795% (-0.008%) from 93.803% when pulling 347019d91c5eb7d2d49570eb22b65862f2f50592 on djhoese:deprecate-area-rotation into f76d5a1910a529f75c1c9b71dff00040e6a9b136 on pytroll:main.