pytroll / pyresample

Geospatial image resampling in Python
http://pyresample.readthedocs.org
GNU Lesser General Public License v3.0
344 stars 95 forks source link

Replace width/height in future AreaDefinition with "shape" argument #533

Closed djhoese closed 1 year ago

djhoese commented 1 year ago

This was discussed in a previous PR regarding cleaning up AreaDefinitions. The basic idea is to reduce the number of arguments passed to an AreaDefinition to keep the interface a little cleaner and simpler. This PR does this by grouping the width and height arguments into a single "shape" tuple.

This also makes it easier to create AreaDefinitions with more than 2 dimensions in the long long term.

codecov[bot] commented 1 year ago

Codecov Report

Merging #533 (3cb9861) into main (82b9373) will increase coverage by 0.00%. Report is 7 commits behind head on main. The diff coverage is 91.66%.

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   94.25%   94.26%           
=======================================
  Files          82       82           
  Lines       13030    13059   +29     
=======================================
+ Hits        12282    12310   +28     
- Misses        748      749    +1     
Flag Coverage Δ
unittests 94.26% <91.66%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pyresample/test/test_resamplers/test_nearest.py 100.00% <ø> (ø)
pyresample/utils/rasterio.py 62.50% <50.00%> (ø)
pyresample/area_config.py 90.58% <100.00%> (ø)
pyresample/future/geometry/area.py 100.00% <100.00%> (ø)
pyresample/test/conftest.py 98.47% <100.00%> (+0.01%) :arrow_up:
pyresample/test/test_geometry/test_area.py 99.22% <100.00%> (+<0.01%) :arrow_up:

... and 3 files with indirect coverage changes

coveralls commented 1 year ago

Coverage Status

coverage: 93.84% (-0.02%) from 93.864% when pulling 3cb9861bf362e6558c0c62dc4aff7da062e2a2e9 on djhoese:feature-areadef-shape into 82b9373a03ae979985e18ef1eaa25ea04a0db530 on pytroll:main.