Open adybbroe opened 9 months ago
It looks like I can assume that self.lons
is an Xarray DataArray, and never (just) a numpy array, correct?
It looks like I can assume that self.lons is an Xarray DataArray, and never (just) a numpy array, correct?
For Satpy, yes, but we can't (and shouldn't) make that assumption for pyresample.
It looks like I can assume that self.lons is an Xarray DataArray, and never (just) a numpy array, correct?
For Satpy, yes, but we can't (and shouldn't) make that assumption for pyresample.
Ok, got me there then! I was looking for tests on that, but found only with xarray, but possible that I just overlooked such tests...
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6a8afc0
) 94.11% compared to head (a7650f4
) 94.14%. Report is 11 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@djhoese I made a comment in the issue: https://github.com/pytroll/pyresample/issues/554#issuecomment-1820556077
Which solution do you propose I pursue? And does @gerritholl and @mraspaud have opinions as well?
This is supposed to solve #554
Make use of the fact that longitudes are an xarray data array and use 'y' dimension for rows/scanlines
This makes the code resilient towards any other (awkward) data layout than the standard (where first dimension is usually the rows).
git diff origin/main **/*py | flake8 --diff