Closed ghiggi closed 10 months ago
Attention: 10 lines
in your changes are missing coverage. Please review.
Comparison is base (
c240c04
) 94.09% compared to head (aee90a1
) 94.06%.
Files | Patch % | Lines |
---|---|---|
pyresample/geometry.py | 81.39% | 8 Missing :warning: |
pyresample/gradient/__init__.py | 81.81% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@djhoese ok now it works. Ready for review and eventually merge ;)
Ugh, that's what I get for trying to fix something in the github GUI. Working on it...
I'll merge this when CI passes. Another idea (for a much later PR) I had and maybe mentioned during out last meeting:
How useful are some of these helper methods outside of boundary creation? What if the new Boundary classes had a .from_area
or .from_geometry
classmethod or how we talked about a factory function (something like boundary_for_geometry(...)
)? All these little helper methods could be moved there and out of the geometry.py module.
git diff origin/main **/*py | flake8 --diff
This PR introduces the methods:
_get_geographic_sides
_get_projection_sides
These two methods allow to retrieve the boundary sides for whatever
pyresample
area, whether is geostationary or not. In a future PR, these two methods will also include the logic to retrieve the boundary ofAreaDefinition
with out-of-Earth coordinates.This PR:
get_area_slices
methodAreaSlicer
andSwathSlicer
class yetBUT :
_get_geographic_sides
is called withinget_bbox_lonlats
get_bbox_lonlats
returns non-Inf
sides vertices for geostationary area !get_edge_lonlats
andboundary()
depends onget_bbox_lonlats
, they now also returns non-Inf
GEO verticesget_bbox_lonlats
has not yet be fixed to be correct._get_geographic_sides
SphericalBoundary
classget_bbox_lonlats
is gonna be deprecated in upcoming PRs_get_projection_sides
SphericalBoundary
andPlanarBoundary
classget_edge_bbox_in_projection_coordinates
inSwathSlicer
/AreaSlicer
get_geostationary_bounding_box_in_proj_coords
inAreaSlicer