Closed mraspaud closed 7 months ago
You brought up nprocs
on slack, do we want to deprecate that with a warning in the old class?
I don't know. On one hand, we should encourage users to go over to dask, but on the other hand, maybe that's a showstopper for some (I have not heard of such myself though)?
I think it is more of the nprocs
on __init__
being a problem. Having it in other places is fine (although could be refactored to be presented differently). For example, getting coordinates or reprojecting or whatever, then nprocs
makes sense as a convenience to say "do it with multiple cores, whatever that means". I don't think dask is usually a show stopper, but it may be an unnecessary dependency in some users eyes. Especially if it becomes a hard requirement when users are totally fine doing everything in numpy land.
Side note: nprocs
could maybe be a global setting in pyresample.config
to hide it away.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
eaf8367
) 94.05% compared to head (5b05353
) 94.01%. Report is 42 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pyresample/future/geometry/swath.py | 95.45% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR adds attrs to the future swath definition.
git diff origin/main **/*py | flake8 --diff