pytroll / pyresample

Geospatial image resampling in Python
http://pyresample.readthedocs.org
GNU Lesser General Public License v3.0
348 stars 94 forks source link

Fix optimize_projection handling in YAML parsing #585

Closed djhoese closed 7 months ago

djhoese commented 7 months ago

Broken in #577. I accidentally stopped passing/parsing optimize_projection to DynamicAreaDefiniton objects parsed from YAML. This was first noticed in Satpy's tests. This PR fixes it. As stated in #577, I'd still like to follow this up with a PR to move metadata from YAML being any random kwarg to being an explicit attrs key.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9c94b08) 93.99% compared to head (4dfcda6) 94.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #585 +/- ## ======================================= Coverage 93.99% 94.00% ======================================= Files 92 92 Lines 13777 13785 +8 ======================================= + Hits 12950 12958 +8 Misses 827 827 ``` | [Flag](https://app.codecov.io/gh/pytroll/pyresample/pull/585/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pytroll/pyresample/pull/585/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `94.00% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 7 months ago

Coverage Status

coverage: 93.66% (+0.004%) from 93.656% when pulling 4dfcda624156d7e62c0c95433dbeac3770c93693 on djhoese:bugfix-opt-proj-yaml into 56da95888466669901bfab6aa96965ff38cee9f2 on pytroll:main.