pytroll / pyresample

Geospatial image resampling in Python
http://pyresample.readthedocs.org
GNU Lesser General Public License v3.0
343 stars 95 forks source link

Fix spill over of ocean/and features in cartopy plots in case of geostationary full disc plot. #601

Open BENR0 opened 1 month ago

BENR0 commented 1 month ago

In case of geostationary full disc plots the boundary of the cartopy CRS needs to be the actual full disc otherwise ocean/land features spill over.

Since the to_cartopy_crs method in pyresample uses a custom Projection class this is a hot fix using code from the Cartopy Geostationary class.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.98%. Comparing base (56f4506) to head (dad4054). Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #601 +/- ## ========================================== - Coverage 94.01% 93.98% -0.03% ========================================== Files 92 86 -6 Lines 13836 13768 -68 ========================================== - Hits 13008 12940 -68 Misses 828 828 ``` | [Flag](https://app.codecov.io/gh/pytroll/pyresample/pull/601/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pytroll/pyresample/pull/601/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `93.98% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 1 month ago

Coverage Status

coverage: 93.685% (+0.009%) from 93.676% when pulling e16203a4e5877d3ad196d5e23bb15e4f382d08c6 on BENR0:feat_html_repr into db94a87b21bfff43eecb71458f54c574dd344833 on pytroll:main.

coveralls commented 17 hours ago

Coverage Status

coverage: 93.686% (+0.01%) from 93.676% when pulling dad40548da5bd427895dac16a80560f1239a38bb on BENR0:feat_html_repr into db94a87b21bfff43eecb71458f54c574dd344833 on pytroll:main.