Open ameraner opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.98%. Comparing base (
56f4506
) to head (f3acfb4
). Report is 16 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I addressed all comments, and most importantly I switched all bucket tests to pytest. I realised there are many ways to do this (like do we need a base test class containing all tests?), so please let me know if you like it like this. I also used fixtures with module scope to optimise it a bit.
I also parametrised the get_sum arguments tests into one test as proposed. It took a while to figure out the combination and simplification of the test flow, but indeed I think it improved the test readability, and made the testing of more corner cases much easier. So thanks for pushing me to do it :)
This PR adds support for
fill_value
andset_empty_bucket_to
in BucketResamplerget_sum
. This is a nice feature, but most importantly it fixes the satpybucket_sum
interface.Closes https://github.com/pytroll/satpy/issues/2805
git diff origin/main **/*py | flake8 --diff