Closed BENR0 closed 1 month ago
Attention: Patch coverage is 81.25000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 93.96%. Comparing base (
f3acfb4
) to head (9c07da9
). Report is 20 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pyresample/_formatting_html.py | 81.25% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like the unstable environment are failing for some related things, but not only related things. I wonder if this is something we could/should fix in this PR:
FAILED pyresample/test/test_formatting.py::test_plot_area_def_w_swath_def[LegacySwathDefinition] - TypeError: ufunc 'create_collection' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
FAILED pyresample/test/test_formatting.py::test_plot_area_def_w_swath_def[SwathDefinition] - TypeError: ufunc 'create_collection' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
FAILED pyresample/test/test_formatting.py::test_area_def_cartopy_installed - TypeError: ufunc 'create_collection' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
FAILED pyresample/test/test_formatting.py::test_area_repr_w_static_files - TypeError: ufunc 'create_collection' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
FAILED pyresample/test/test_formatting.py::test_area_repr_wo_static_files - TypeError: ufunc 'create_collection' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
FAILED pyresample/test/test_sgeom/test_point.py::TestSMultiPoint::test_to_shapely - TypeError: ufunc 'create_collection' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
Bug report for the failures: https://github.com/shapely/shapely/issues/2098
Let's merge this since these failures are not your fault and are in the unstable environment.
This is a quick fix for #609. It just sets things like resolution and width/height to Na in the case of 1D lat/lon arrays so the html representation does not break. It also does some quick fixing of formatting issues I noticed.
git diff origin/main **/*py | flake8 --diff