pytroll / pytroll-aapp-runner

Pytroll runner for AAPP
http://pytroll-aapp-runner.readthedocs.io/en/develop/
GNU General Public License v3.0
1 stars 8 forks source link

Copy TLE file to archive at most once #11

Closed gerritholl closed 3 years ago

gerritholl commented 3 years ago

Make sure that a TLE file gets copied to the archive at most once, by stopping processing when a regular expression matches. This has the potential to break backward compatibility, but I think it's unlikely that parsing a regular expression based on a partial match is desired, as the additional archival directory names would be incorrect. In the process, I have refactored the module tle_satpos_prepare.py, added the first test case for pytroll-aapp-runner, adapted .travis.yml, and updated the Python version to the modern era.

ghost commented 3 years ago

DeepCode's analysis on #253d3a found:

Description Example fixes
Undefined variable 'breakpoint' Occurrences: :wrench: Example fixes
Either all return statements in a function should return an expression, or none of them should. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

gerritholl commented 3 years ago

@pytroll/core Maybe someone with owner permissions on pytroll-aapp-runner can enable Travis CI? There was actually a .travis.yml already before this PR but no unit tests. I'm adding the first unit test here and having CI on Github would be useful.

gerritholl commented 3 years ago

Can someone with triage permissions request reviews from @TAlonglong and @adybbroe? Those seem to have done the most work on this module so far.

mraspaud commented 3 years ago

done

adybbroe commented 3 years ago

Great, thanks @gerritholl for contributing and bringing this repo closer to the modern era! :-)

adybbroe commented 3 years ago

I will merge, and start getting this latest version up and running at SMHI. Then we will see how well it fits our environment.