Bugfix: Nameservers list should be None on default

pytroll / pytroll-aapp-runner

Pytroll runner for AAPP

http://pytroll-aapp-runner.readthedocs.io/en/develop/

GNU General Public License v3.0

1 stars 8 forks source link

Bugfix: Nameservers list should be None on default #21

Closed adybbroe closed 3 years ago

adybbroe commented 3 years ago

When calling the aapp-runner it is possible to list the destination hosts where downstream processes are able to listen. Right now this defaults to ["localhost"] resulting in switching off multicasting.

This PR puts the default to None which results in multicast and give a more expected behaviour.

[ ] Closes #xxxx
[ ] Tests added
[ ] Tests passed: Passes pytest
[ ] Passes flake8
[ ] Fully documented

gerritholl commented 3 years ago

Expected is subjective. Personally I run all the polar processing on one host and haven't understood the need for multicasting. But since I'm starting aapp_dr_runner.py with the flag -n localhost I think it should not make a difference for us. I hope the same is true for others who use localhost.

ghost commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

pnuu commented 3 years ago

I also always disable multicast, it just creates unnecessary connections to unrelated servers with nameservers, subscribers and publishers.