pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

Add an s3stalker daemon #114

Closed adybbroe closed 1 year ago

adybbroe commented 2 years ago

Add a runner or demon to stalk for new files in an S3 bucket based on the s3stalker script

codecov[bot] commented 2 years ago

Codecov Report

Merging #114 (456c73b) into main (62a1d71) will increase coverage by 0.69%. The diff coverage is 99.64%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   90.52%   91.22%   +0.69%     
==========================================
  Files          22       27       +5     
  Lines        3577     3998     +421     
==========================================
+ Hits         3238     3647     +409     
- Misses        339      351      +12     
Flag Coverage Δ
unittests 91.22% <99.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytroll_collectors/tests/test_fsspec_to_message.py 93.29% <ø> (ø)
pytroll_collectors/tests/test_s3stalker.py 99.46% <99.21%> (-0.54%) :arrow_down:
pytroll_collectors/s3stalker.py 100.00% <100.00%> (ø)
pytroll_collectors/s3stalker_daemon_runner.py 100.00% <100.00%> (ø)
pytroll_collectors/scisys.py 62.18% <100.00%> (ø)
...l_collectors/tests/test_s3stalker_daemon_runner.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adybbroe commented 1 year ago

Damn. Moving the self._setup_and_start_communication()from the init to the run method as suggested was a bad idea I am afraid, it gives me this error: ValueError: signal only works in main thread of the main interpreter So, I am moving it back into the init @pnuu

adybbroe commented 1 year ago

Damn. Moving the self._setup_and_start_communication()from the init to the run method as suggested was a bad idea I am afraid, it gives me this error: ValueError: signal only works in main thread of the main interpreter So, I am moving it back into the init @pnuu

Oh, I see now, that you only suggested moving the publisher creation to the run method, sorry will redo...

mraspaud commented 1 year ago

@pnuu I have addressed or answered your comments...

pnuu commented 1 year ago

I went through the unresolved comments, and only my two latest ones are still open.

For some reason GitHub shows some of the comments without the ability to resolve them, so the comment section is a bit messy.