pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

Ensure files in S3 keep their full URIs in messages #118

Closed pnuu closed 2 years ago

pnuu commented 2 years ago

This PR makes sure that segments collected from S3 keep their full URIs. Previously the scheme and bucket name were stripped away.

codecov[bot] commented 2 years ago

Codecov Report

Merging #118 (78ca19b) into main (81ee9b2) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   89.91%   89.97%   +0.05%     
==========================================
  Files          25       25              
  Lines        3680     3701      +21     
==========================================
+ Hits         3309     3330      +21     
  Misses        371      371              
Impacted Files Coverage Δ
pytroll_collectors/segments.py 92.11% <100.00%> (-0.03%) :arrow_down:
pytroll_collectors/tests/test_segments.py 99.27% <100.00%> (+0.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mraspaud commented 2 years ago

Should be just pass through everything and let downstream applications do the stripping?

pnuu commented 2 years ago

Maybe. This just keeps the backwards compatibility.

mraspaud commented 2 years ago

ok, but for consistency then? the geographic gatherer lets the uri pass through... trollflow/satpy can handle these anyway, right?

pnuu commented 2 years ago

Good point. Now all incoming URIs are passed as-is.