Closed pnuu closed 2 years ago
Merging #118 (78ca19b) into main (81ee9b2) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 89.91% 89.97% +0.05%
==========================================
Files 25 25
Lines 3680 3701 +21
==========================================
+ Hits 3309 3330 +21
Misses 371 371
Impacted Files | Coverage Δ | |
---|---|---|
pytroll_collectors/segments.py | 92.11% <100.00%> (-0.03%) |
:arrow_down: |
pytroll_collectors/tests/test_segments.py | 99.27% <100.00%> (+0.02%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Should be just pass through everything and let downstream applications do the stripping?
Maybe. This just keeps the backwards compatibility.
ok, but for consistency then? the geographic gatherer lets the uri pass through... trollflow/satpy can handle these anyway, right?
Good point. Now all incoming URIs are passed as-is.
This PR makes sure that segments collected from S3 keep their full URIs. Previously the scheme and bucket name were stripped away.