pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 19 forks source link

Bugfix segment gathering when segment name has a dash in it #131

Closed pnuu closed 1 year ago

pnuu commented 1 year ago

This is a fix for segment gathering case where a segment name has a dash in it, like CRR-Ph.

The filename composition tests were refactored along the way.

codecov[bot] commented 1 year ago

Codecov Report

Merging #131 (b274001) into main (f8ed96c) will increase coverage by 0.34%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   90.15%   90.50%   +0.34%     
==========================================
  Files          25       25              
  Lines        3779     3865      +86     
==========================================
+ Hits         3407     3498      +91     
+ Misses        372      367       -5     
Impacted Files Coverage Δ
pytroll_collectors/segments.py 92.32% <100.00%> (+0.20%) :arrow_up:
pytroll_collectors/tests/test_segments.py 100.00% <100.00%> (+0.72%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pnuu commented 1 year ago

@mraspaud @adybbroe any comments?