Closed pnuu closed 1 year ago
Apparently the filesystem stuff was expected to be in the messages, so lets just drop the S3 credentials we know of.
Merging #136 (bc0e68e) into main (e3b9abc) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 91.32% 91.36% +0.04%
==========================================
Files 27 27
Lines 4044 4065 +21
==========================================
+ Hits 3693 3714 +21
Misses 351 351
Flag | Coverage Δ | |
---|---|---|
unittests | 91.36% <100.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pytroll_collectors/fsspec_to_message.py | 98.03% <100.00%> (+0.10%) |
:arrow_up: |
pytroll_collectors/tests/test_fsspec_to_message.py | 93.71% <100.00%> (+0.42%) |
:arrow_up: |
... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Totals | |
---|---|
Change from base Build 4797690011: | 0.0% |
Covered Lines: | 0 |
Relevant Lines: | 0 |
Totals | |
---|---|
Change from base Build 4797690011: | 0.0% |
Covered Lines: | 0 |
Relevant Lines: | 0 |
The messages published by S3Stalker(daemon) had all the credentials published in the messages. ~This PR drops the whole
filesystem
part of the message, which needs to be configured at the receiving side in any case.~Update: only drop known S3 credentials.