search

pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

Use factory function for publisher creation in trollstalker and switch to Watchdog #152

Closed mraspaud closed 7 months ago

mraspaud commented 7 months ago

This PR uses factory function for publisher creation in trollstalker and switches it to Watchdog

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7871571797

Details

Totals Coverage Status
Change from base Build 7828186224: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls
codecov[bot] commented 7 months ago

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (7965e59) 90.76% compared to head (ed449f1) 91.23%. Report is 2 commits behind head on main.

:exclamation: Current head ed449f1 differs from pull request most recent head 87045bc. Consider uploading reports for the commit 87045bc to get more accurate results

Files Patch % Lines
pytroll_collectors/trollstalker.py 77.43% 37 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== + Coverage 90.76% 91.23% +0.46% ========================================== Files 32 32 Lines 4420 4416 -4 ========================================== + Hits 4012 4029 +17 + Misses 408 387 -21 ``` | [Flag](https://app.codecov.io/gh/pytroll/pytroll-collectors/pull/152/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pytroll/pytroll-collectors/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `91.23% <82.21%> (+0.46%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mraspaud commented 7 months ago

The blacklisting of watchdog 4.0.0 is because of a bug solved in: https://github.com/gorakhargosh/watchdog/pull/1032