pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 19 forks source link

Add SIGTERM handling to segment gatherer #156

Closed pnuu closed 1 week ago

pnuu commented 1 week ago

This PR adds SIGTERM handling to segment gatherer.

After receiving the signal, the gatherer will wait until all active collections have been finished and then exit the program.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 71.42857% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (80956c4) to head (3409378). Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pytroll_collectors/segments.py 35.71% 9 Missing :warning:
pytroll_collectors/tests/test_segments.py 85.71% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ========================================== + Coverage 91.23% 91.82% +0.59% ========================================== Files 32 28 -4 Lines 4417 3953 -464 ========================================== - Hits 4030 3630 -400 + Misses 387 323 -64 ``` | [Flag](https://app.codecov.io/gh/pytroll/pytroll-collectors/pull/156/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pytroll/pytroll-collectors/pull/156/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll) | `91.82% <71.42%> (+0.59%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pytroll#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11815651515

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pytroll_collectors/tests/test_segments.py 30 35 85.71%
pytroll_collectors/segments.py 5 14 35.71%
<!-- Total: 35 49 71.43% -->
Totals Coverage Status
Change from base Build 7932120988: 91.0%
Covered Lines: 4062
Relevant Lines: 4462

💛 - Coveralls