pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

PyToCh Gatherer: Add hour filter pattern #40

Closed tecnavia-dev closed 5 years ago

tecnavia-dev commented 5 years ago

Some new features added: Gatherer

mraspaud commented 5 years ago

Thanks for submitting all the changes. As these provide multiple functionality, would it be possible for you to make one PR per functionality instead ? One for gatherer and two for trollstalker. It will be easier to discuss and improve on each one that way.

Regarding the launch.json file, I think it's best not to integrate it in this package:

mraspaud commented 5 years ago

Also, could you change the title of this PR to make it more descriptive ? Right now it doesn't say anything on the content of the PR.

mraspaud commented 5 years ago

Can I close this PR ? It looks like other PRs are going to replace this one, right ?

tecnavia-dev commented 5 years ago

Yes and also #33 of Vincenzo

mraspaud commented 5 years ago

Thanks