Closed pnuu closed 4 years ago
Merging #47 into master will decrease coverage by
0.08%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
- Coverage 4.37% 4.29% -0.09%
=========================================
Files 18 18
Lines 2786 2838 +52
=========================================
Hits 122 122
- Misses 2664 2716 +52
Impacted Files | Coverage Δ | |
---|---|---|
pytroll_collectors/segments.py | 0% <0%> (ø) |
:arrow_up: |
pytroll_collectors/tests/test_segments.py | 0% <0%> (ø) |
:arrow_up: |
pytroll_collectors/helper_functions.py | 15.88% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 95dcdbe...49fdd5a. Read the comment docs.
Tested this with real-time data from Eumetcast. Rather surprisingly works :grin:
As far as I can see this looks good.
Thanks to @mraspaud for pointing out that the previous solution was pretty convoluted. This should be much easier for the user to understand and configure.
Nice @pnuu !
Could you add some explanation at least in the ini file of the group_by_minutes
variable?
Thanks @TAlonglong! I had also forgotten to adjust the file pattern for the Himawari-8 example config.
This PR makes it possible to group segments for given full minutes.
The feature makes it possible to collect e.g. Himawari-8 segments that otherwise would require 6 separate collectors (one for each 10-minute slot), and then would have incorrect time attached for slots not starting at full hour. To configure (see full example in
examples/segment_gatherer.ini_template
,[himawari-8]
section):This means that the segments are group for every full 10 minute period. This period can be anything from
1
(group for every full minute) onwards. Values equal or greater than60
will group the data to full hours.The last option means that the
start_time
parsed from the filename is not overwritten by the time given in the incoming message. Any other tags in the pattern can be given in same way.