Closed TAlonglong closed 4 years ago
Merging #60 into master will increase coverage by
0.57%
. The diff coverage is95.00%
.
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 62.48% 63.05% +0.57%
==========================================
Files 14 14
Lines 2015 2049 +34
==========================================
+ Hits 1259 1292 +33
- Misses 756 757 +1
Impacted Files | Coverage Δ | |
---|---|---|
pytroll_collectors/segments.py | 66.82% <83.33%> (+0.23%) |
:arrow_up: |
pytroll_collectors/tests/test_segments.py | 97.83% <100.00%> (+0.20%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d8ca767...e2795ad. Read the comment docs.
Pleas give this a look when you can spare some minutes @mraspaud and @pnuu
Thanks for fixing the minutes grouping with the hour patterns feature. Could you add a test ? This will probably help me understand the modifications better.
Hm ok. I will see what I can do
But is the test, at least for segments ( test_segments.py) run at all? If I try at the command line it fails.
Can you please have a look when you have time?
I'll have a quicklook now
Tada
Looks good @TAlonglong, thanks for rooting out the testing/coverage problem. @tecnavia-dev it would be great if you could have a look at this! I'll merge this tomorrow if I don't hear from you.
If you have more than one patterns you might need to set the group_by_minute and keep_parsed_keys in the config different for each patterns.
eg: (yaml config)
Without this PR it is only possible to give these for all patterns.