pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

Add Github Action to run unit tests #81

Closed pnuu closed 3 years ago

pnuu commented 3 years ago

This PR adds a Github Action that runs the unit tests. Non-functional Travis CI integration is remvoed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (0454b3a) into master (2e43255) will increase coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   72.65%   72.85%   +0.19%     
==========================================
  Files          14       13       -1     
  Lines        2454     2461       +7     
==========================================
+ Hits         1783     1793      +10     
+ Misses        671      668       -3     
Impacted Files Coverage Δ
pytroll_collectors/segments.py 89.58% <ø> (+0.15%) :arrow_up:
pytroll_collectors/trigger.py 61.72% <100.00%> (ø)
pytroll_collectors/_version.py 41.57% <0.00%> (-1.03%) :arrow_down:
pytroll_collectors/tests/test_segments.py 99.15% <0.00%> (+<0.01%) :arrow_up:
pytroll_collectors/tests/test_trigger.py 92.42% <0.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e36ae8f...0454b3a. Read the comment docs.

pnuu commented 3 years ago

There are plenty of cases where Thread.__init__(self) is used, but they should be something like super(NameOfThisClass, self).__init__(). As the test coverage is pretty poor and I have no intention on adding tests on this PR, I just fixed the one that caused the existing tests to fail.

ghost commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.