pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

Add capability to monitor for silence in geographic gathering #89

Open gerritholl opened 3 years ago

gerritholl commented 3 years ago

Add an option to monitor for silence in geographic gathering. This adds a timeout calculation that is triggered at a certain time after the most recent message has arrived. This allows for early shipping if a reception system has stopped delivering earlier than expected or if the region is defined too large.

Work in progress. So far only the tests have been added.

codecov[bot] commented 3 years ago

Codecov Report

Merging #89 (1bb84b8) into main (e6e95b0) will increase coverage by 0.18%. The diff coverage is 100.00%.

:exclamation: Current head 1bb84b8 differs from pull request most recent head bf5bf83. Consider uploading reports for the commit bf5bf83 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   83.33%   83.52%   +0.18%     
==========================================
  Files          19       19              
  Lines        2622     2652      +30     
==========================================
+ Hits         2185     2215      +30     
  Misses        437      437              
Impacted Files Coverage Δ
pytroll_collectors/region_collector.py 82.23% <100.00%> (+0.72%) :arrow_up:
...troll_collectors/tests/test_geographic_gatherer.py 100.00% <100.00%> (ø)
pytroll_collectors/tests/test_region_collector.py 94.59% <100.00%> (+1.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6e95b0...bf5bf83. Read the comment docs.

gerritholl commented 3 years ago

I'm currently field-testing this (along with #92, without which the geographic gatherer doesn't start).

gerritholl commented 3 years ago

Initial field-testing indicates it is not entirely working as expected, so I'm marking this as a draft again for now.