search

pytroll / pytroll-collectors

Collector modules for Pytroll
GNU General Public License v3.0
3 stars 18 forks source link

Limit geographic gathering using overpass schedules #90

Closed pnuu closed 3 years ago

pnuu commented 3 years ago

This is a rework of #53 after the restructuring of geographic gathering.

Closes #52

codecov[bot] commented 3 years ago

Codecov Report

Merging #90 (1118b60) into main (71d66a1) will increase coverage by 1.10%. The diff coverage is 96.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   83.26%   84.37%   +1.10%     
==========================================
  Files          19       21       +2     
  Lines        2624     2854     +230     
==========================================
+ Hits         2185     2408     +223     
- Misses        439      446       +7
Impacted Files Coverage Δ
pytroll_collectors/region_collector.py 81.25% <80.00%> (-0.26%) :arrow_down:
...oll_collectors/tests/test_harvest_EUM_schedules.py 96.00% <96.00%> (ø)
pytroll_collectors/geographic_gatherer.py 84.21% <100.00%> (+1.01%) :arrow_up:
pytroll_collectors/harvest_EUM_schedules.py 100.00% <100.00%> (ø)
...troll_collectors/tests/test_geographic_gatherer.py 100.00% <100.00%> (ø)
pytroll_collectors/tests/test_region_collector.py 96.03% <100.00%> (+3.31%) :arrow_up:
pytroll_collectors/helper_functions.py 67.30% <0.00%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71d66a1...1118b60. Read the comment docs.

TAlonglong commented 3 years ago

Did you try to add me as reviewer on this one @pnuu? I can't see any places to start reviewing. hm

pnuu commented 3 years ago

Hmm, GitHub seems to allow only Martin, Lars, Adam and Dave. I'll see if I can find a way to add you.

pnuu commented 3 years ago

@TAlonglong ok, I added you as a maintainer for the repository and then you were available as a reviewer.

pnuu commented 3 years ago

You should now be able to add commits, as you are maintainer of the repository.

TAlonglong commented 3 years ago

Do you mind if I try to clean up a bit?

pnuu commented 3 years ago

Please do :grin:

TAlonglong commented 3 years ago

Hm, I can't figure out how to do this. The branch is in your fork. And I guess I need to contribute to that for this to be added in this PR.

TAlonglong commented 3 years ago

OK @pnuu, Some of the test did not actually test much, so I added some checks. With this work I saw there was actually to readlines call after opening a cached file. So I fixed this also.

The codefactor is some temporary directory and use of urlopen. And, I guess, a big job refactor the region_collector. I will leave that for a later task? What do you think?

pnuu commented 3 years ago

If you think this is ready, I'm ok for merging. Does @mraspaud have any comments?

TAlonglong commented 3 years ago

Ah, thats a good point. I will look into this.

TAlonglong commented 3 years ago

Hm, I don't see this test fail when running the test locally. But I need to make some dinner now. Maybe check inn later.