pytroll / pytroll-examples

Collection of examples for pytroll satellite data processing
GNU General Public License v3.0
76 stars 34 forks source link

Notebook for the NWCSAF User workshop 2020 #24

Closed adybbroe closed 4 years ago

adybbroe commented 4 years ago

Add notebook for the NWCSAF User workshop 2020

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

adybbroe commented 4 years ago

Would be nice if anyone could run the notebook as is without first having to download the data to /tmp. Did you @djhoese have a "solution" for that?

djhoese commented 4 years ago

No real solution. We either access data that the data provider's put on the cloud (and make sure Satpy can read directly from the URL whatever protocol it is) or we have specific bundles (zips, tarballs, etc) that we can download in the notebook. satpy.demo does this for ABI data on Google Cloud Platform.

I personally am not sure this notebook should be in this repository and could have its own repository, but I can be convinced otherwise. Eh I don't know this is a close one. An example Satpy notebook that isn't showing off a particular feature of Satpy maybe shouldn't...I don't know. I'm worried we are going to get too many notebooks and it will be even harder to sort through.

review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

mraspaud commented on 2020-03-10T13:17:26Z ----------------------------------------------------------------

you could maybe give an example wget command to download the data ?


review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

mraspaud commented on 2020-03-10T13:17:27Z ----------------------------------------------------------------

Why not use print(scene['ct'].shape) and .compute directly ? this way you can show how dimension and metadata are also provided


review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

mraspaud commented on 2020-03-10T13:17:28Z ----------------------------------------------------------------

This could be misleading if both bzipped and unzipped versions of the files are present in the directory. It could lead to some data duplication in the image.


review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

mraspaud commented on 2020-03-10T13:17:29Z ----------------------------------------------------------------

could it be worth it do define the coastlines directory as a constant at the beginning of the notebook for clarity, with a link to instructions on how to download them ?


mraspaud commented 4 years ago

Also, maybe resampling to omerc_bb could be of interest ?

adybbroe commented 4 years ago

@djhoese I see what you mean and tend to agree! Maybe I should have made this a separate repo... Can we have it here for the time being and clean it up later? Hmm, the risk is that noone takes the time cleaning it up until it is too big

djhoese commented 4 years ago

Maybe we make this one of the main agenda items next status meeting? I think this is fine for now.

adybbroe commented 4 years ago

@djhoese I see what you mean and tend to agree! Maybe I should have made this a separate repo... Can we have it here for the time being and clean it up later? Hmm, the risk is that noone takes the time cleaning it up until it is too big

View / edit / reply to this conversation on ReviewNB

mraspaud commented on 2020-03-10T13:17:27Z

Why not use print(scene['ct'].shape) and .compute directly ? this way you can show how dimension and metadata are also provided

How do you mean, not following?

mraspaud commented 4 years ago

Why not use print(scene['ct'].shape) and .compute directly ? this way you can show how dimension and metadata are also provided

How do you mean, not following?

I mean show the xr.dataarray, not the dask/numpy array

review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

djhoese commented on 2020-03-11T12:39:44Z ----------------------------------------------------------------

You can get rid of the start/end time stuff and do filename='./ears_nwc_ctth_{start_time:%Y%m%dT%H%MZ}_{end_time:%Y%m%dT%H%MZ}.png and drop the .format completely.


review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

djhoese commented on 2020-03-11T12:39:45Z ----------------------------------------------------------------

start/end here too