search

pytroll / pytroll-examples

Collection of examples for pytroll satellite data processing
GNU General Public License v3.0
76 stars 34 forks source link

Obsolete keyword argument in Himawari-8 True Color example #48

Open pnuu opened 2 years ago

pnuu commented 2 years ago

In this example, Scene is given an obsolete keyword argument sensor. It appears the example was made when we still supported Python 2.7, so there might be some other obsolete bits, too.

gerritholl commented 2 years ago

Would it be possible to automatically run the notebooks for any PR in Satpy, Pyresample, and other relevant projects?

pnuu commented 2 years ago

Only if the data are available and there are enough resources to run with real data.

gerritholl commented 2 years ago

On the European Weather Cloud? Then maybe not for every PR but overnight with main (if main has changed).

mraspaud commented 2 years ago

yes, we need to do that. For the benchmarking there, we already have some data locally too.

djhoese commented 2 years ago

I think if we had a cronjob on EWC that rsync'd (or at least compared what files exist locally before re-downloading) public ABI data from AWS, public AHI data from , and SEVIRI data from EWC then we could probably update the examples to use most of the same data. I also have my zip files of data from my tutorial that the various tutorials here could use and the EWC virtual machines could download/cache and then run notebooks against. It is just a matter of making the examples use relative paths.

I guess we could actually just make all of that done as part of the demo data subpackage in satpy. That's what it was meant for originally anyway. That way users don't have to wonder why Satpy is complaining about not having files that the examples are clearly expecting.