pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

Refactor the pps posttroll messaging hook and add unittests #17

Closed adybbroe closed 3 years ago

adybbroe commented 3 years ago

Refactoring of the pps posttroll messaging hook. Adding unittests

ghost commented 3 years ago

DeepCode's analysis on #46b23d found:

Description Example fixes
Unused PPSMessage imported from nwcsafpps_runner.pps_posttroll_hook Occurrences: :wrench: Example fixes
Access to a protected member _to_send of a client class Occurrences: :wrench: Example fixes
standard import "import unittest" should be placed before "import pytest" Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

adybbroe commented 3 years ago

Okay, I merge this now. It has been tested at SMHI for a while now, and it seem to work