search

pytroll / pytroll-pps-runner

Pytroll runner for PPS
GNU General Public License v3.0
1 stars 8 forks source link

Fix pygrib openfiles #20

Closed adybbroe closed 3 years ago

adybbroe commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (5ad39b9) into master (201454a) will decrease coverage by 0.07%. The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   27.87%   27.80%   -0.08%     
==========================================
  Files          11       11              
  Lines        1693     1705      +12     
==========================================
+ Hits          472      474       +2     
- Misses       1221     1231      +10
Flag Coverage Δ
unittests 27.80% <9.52%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwcsafpps_runner/prepare_nwp.py 0.00% <0.00%> (ø)
nwcsafpps_runner/utils.py 26.84% <100.00%> (+0.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 201454a...5ad39b9. Read the comment docs.

mraspaud commented 3 years ago

LGTM, feel free to merge once the tests pass.

adybbroe commented 3 years ago

Thanks @mraspaud I think it will fail on Ubuntu-latest. Something with gdal-config. I couldn't really see what I could do to make it pass, so I left it for now. Already a good step forward to have testing on github I thought.

adybbroe commented 3 years ago

Oh, it also fails on Windows, as I have hardcoded Linux style filepaths in the tests. The code had never run under Windows yet, as far as we know, so I will ignore this here, and address it in a separate PR