Codecov Report

Merging #29 (0d925e7) into main (a622f50) will increase coverage by 3.67%. The diff coverage is 73.78%.

:exclamation: Current head 0d925e7 differs from pull request most recent head 260baf6. Consider uploading reports for the commit 260baf6 to get more accurate results

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   48.96%   52.63%   +3.67%     
==========================================
  Files          14       14              
  Lines        1640     1763     +123     
  Branches      216      221       +5     
==========================================
+ Hits          803      928     +125     
+ Misses        825      817       -8     
- Partials       12       18       +6

Flag	Coverage Δ
unittests	`52.63% <73.78%> (+3.67%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
nwcsafpps_runner/logger.py	`0.00% <0.00%> (ø)`
nwcsafpps_runner/pps_posttroll_hook.py	`77.24% <ø> (ø)`
nwcsafpps_runner/prepare_nwp.py	`0.00% <0.00%> (ø)`
nwcsafpps_runner/publish_and_listen.py	`0.00% <0.00%> (ø)`
nwcsafpps_runner/utils.py	`30.98% <45.05%> (+4.37%)`	:arrow_up:
nwcsafpps_runner/config.py	`38.55% <100.00%> (+18.32%)`	:arrow_up:
nwcsafpps_runner/tests/test_config.py	`100.00% <100.00%> (ø)`
nwcsafpps_runner/tests/test_level1c_runner.py	`99.27% <100.00%> (ø)`
nwcsafpps_runner/tests/test_utils.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a622f50...260baf6. Read the comment docs.

TAlonglong commented 3 years ago

Nice work @adybbroe. Please let me know when its ready for review

adybbroe commented 2 years ago

Okay, ready for review @TAlonglong But not so easy perhaps!?

adybbroe commented 2 years ago

I have followed most (if not all) of your suggestions now. I need to check that it still works locally (system testing) with v2018. Also, would be good to verify again that it works for v2021 as well. Once that is verified positively I agree we should rename the runner to pps_runner (replacing the old one).

adybbroe commented 2 years ago

This version is now tested with v2018 and AVHRR/MODIS. There is something now here that doesn't work with VIIRS, but not sure what it is yet. Haven't had the time yet. I suggest we merge this one, and make smaller PRs for what might remain to make it work for all instruments and both PPS versions. Including the renaming of the pps2018_runner script.

pytroll / pytroll-pps-runner

Add pps2021 support #29

Codecov Report